From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Kefu Chai <k.chai@proxmox.com>
Subject: applied: [PATCH manager 1/1] ceph: tools: fix local monitor detection in purge_all_ceph_files
Date: Tue, 12 May 2026 04:09:48 +0200 [thread overview]
Message-ID: <177855178710.1260779.3779149581744027860.b4-ty@b4> (raw)
In-Reply-To: <20260331012746.763863-2-k.chai@proxmox.com>
On Tue, 31 Mar 2026 09:27:46 +0800, Kefu Chai wrote:
> The grep call checking whether a monitor's address is in the configured
> mon list did not reference $_, so it never performed a membership test:
>
> $is_local_mon = grep($type->{$name}->{addr}, @$monlist)
>
> In Perl, grep(EXPR, LIST) aliases $_ to each element, but EXPR here is
> '$type->{$name}->{addr}', which ignores $_. This is analogous to the
> following Python, where the filter predicate is a constant:
>
> [...]
Applied, thanks!
[1/1] ceph: tools: fix local monitor detection in purge_all_ceph_files
commit: 0ff270f5be45c114e11a2bf87eafe0dbd06eb2b9
next prev parent reply other threads:[~2026-05-12 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 1:27 [PATCH manager 0/1] ceph: tools: fix local monitor detection in purge_all_ceph_files Kefu Chai
2026-03-31 1:27 ` [PATCH manager 1/1] " Kefu Chai
2026-05-12 2:09 ` Thomas Lamprecht [this message]
2026-05-08 1:32 ` [PATCH manager] " Kefu Chai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177855178710.1260779.3779149581744027860.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.