From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 75C771FF13F
	for <inbox@lore.proxmox.com>; Thu, 07 May 2026 11:28:25 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 444AA11538;
	Thu,  7 May 2026 11:28:25 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Subject: applied: [PATCH pve-manager] ui: qemu: wizard: re-add media=cdrom for
 second VirtIO drivers ISO
Date: Thu,  7 May 2026 11:28:09 +0200
Message-ID: <177814608251.2839738.14339648608584182467.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260507065517.237996-1-a.bied-charreton@proxmox.com>
References: <20260507065517.237996-1-a.bied-charreton@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1778145993413
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.003 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: K5JTFVNAASXYVIRCX4SVODJQIUFPN7ZY
X-Message-ID-Hash: K5JTFVNAASXYVIRCX4SVODJQIUFPN7ZY
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: d.riley@proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Thu, 07 May 2026 08:55:17 +0200, Arthur Bied-Charreton wrote:
> Commit f196d28f moved the ISO selector out of OSTypeInputPanel to a
> new OSPanel component, but left the onGetValues hook that appends the
> `media=cdrom` behind on OSTypeInputPanel, where ide0 now no longer
> appears.
> 
> As a result, creating a Windows guest with the "Add additional drive for
> VirtIO drivers" checkbox enabled fails due to the missing explicit
> media=cdrom.
> 
> [...]

Applied, thanks!

[1/1] ui: qemu: wizard: re-add media=cdrom for second VirtIO drivers ISO
      commit: dc12d54446047b2f4fffc9876e1bc072647cc8ff