From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: applied: [PATCH proxmox-backup] sync: rename change-detection-fingerprint to sync-source-signature
Date: Tue, 28 Apr 2026 20:11:32 +0200 [thread overview]
Message-ID: <177739988818.1498991.3876506656748367562.b4-ty@b4> (raw)
In-Reply-To: <20260428143642.1012584-1-c.ebner@proxmox.com>
On Tue, 28 Apr 2026 16:36:42 +0200, Christian Ebner wrote:
> Introduced in 87a819311 ("datastore: manifest: add helper for change
> detection fingerprint") the name was found to be confusion due to
> the potential metal clash with the totally unrelated client parameter
> named `change-detecton-mode`, especially in log output.
>
> The new field name `sync-source-signature` better reflects that this
> is the signature of the sync source snapshot stored on the target.
> The previous field is kept for backwards compatibility with already
> synced snapshots storing the field, the methods, comments and log
> messages all updated accordingly.
>
> [...]
Applied, thanks!
[1/1] sync: rename change-detection-fingerprint to sync-source-signature
commit: ca5e9e46bcb8b411522e851907c900a10ee9e9cd
prev parent reply other threads:[~2026-04-28 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 14:36 [PATCH proxmox-backup] sync: rename change-detection-fingerprint to sync-source-signature Christian Ebner
2026-04-28 18:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177739988818.1498991.3876506656748367562.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.