From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0698A1FF148 for ; Mon, 27 Apr 2026 11:05:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CFDAF15E3D; Mon, 27 Apr 2026 11:05:03 +0200 (CEST) Date: Mon, 27 Apr 2026 11:04:24 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH proxmox-backup 0/3] sync: clean up manifest/archive load handling To: pbs-devel@lists.proxmox.com References: <20260427084952.303245-1-f.gruenbichler@proxmox.com> In-Reply-To: <20260427084952.303245-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1777280633.voijfg919s.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777280573377 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YEKYYTOZZLYJ2QVBXZI3U23XVYIEWEFN X-Message-ID-Hash: YEKYYTOZZLYJ2QVBXZI3U23XVYIEWEFN X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: forgot to add this here - this would be an alternative to Dominik's patch in https://lore.proxmox.com/pbs-devel/1777277236.2hvl2my85r.astroid@y= una.none On April 27, 2026 10:49 am, Fabian Gr=C3=BCnbichler wrote: > this series cleans up load_file_into by > - moving the File -> DataBlob conversion to the manifest variant call > site > - moving the "skip snapshot" logging to the call site to allow using a > LogLineSender >=20 > Fabian Gr=C3=BCnbichler (3): > sync: return File in load_file_into > pull: do not allow archive fetching to return no archive > pull: move logging of disappeared snapshots >=20 > src/server/pull.rs | 19 ++++++++++++++++--- > src/server/sync.rs | 14 +++++--------- > 2 files changed, 21 insertions(+), 12 deletions(-)