From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup] sync: pull: use LogLineSender also for `load_file_into`
Date: Mon, 27 Apr 2026 10:50:32 +0200 [thread overview]
Message-ID: <1777279805.gmg78bgrrx.astroid@yuna.none> (raw)
In-Reply-To: <1777277236.2hvl2my85r.astroid@yuna.none>
On April 27, 2026 10:19 am, Fabian Grünbichler wrote:
> On April 27, 2026 9:55 am, Dominik Csapak wrote:
>> [..]
> IMHO this should only return Ok(None), the `ok()` call at the end of
> this fn seems quite weird - if we load a file and the CRC check fails,
> we should not silently ignore this?
>
> this also only makes sense for the manifest, for the archives handling
> this correctly would make for earlier error handling..
>
> I'll send an alternative version doing that..
sent: https://lore.proxmox.com/pbs-devel/20260427084952.303245-1-f.gruenbichler@proxmox.com/T/#u
prev parent reply other threads:[~2026-04-27 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 7:55 [PATCH proxmox-backup] sync: pull: use LogLineSender also for `load_file_into` Dominik Csapak
2026-04-27 8:19 ` Fabian Grünbichler
2026-04-27 8:50 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1777279805.gmg78bgrrx.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.