all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: applied: [PATCH proxmox-backup 0/3] fixup client log fetching and decryption
Date: Sat, 25 Apr 2026 21:37:25 +0200	[thread overview]
Message-ID: <177714584411.2472936.17244011036690851535.b4-ty@b4> (raw)
In-Reply-To: <20260425140927.928214-1-c.ebner@proxmox.com>

On Sat, 25 Apr 2026 16:09:24 +0200, Christian Ebner wrote:
> This patches fix a few issues with the client log fetching for pull
> sync jobs:
> 1. Local pull syncs did not fetch the client log at all, add the
>    missing implementation thereof.
> 2. While fetching the client log, some logs were still not using the
>    log line sender, required since introduction of the parallel group
>    sync feature for correctly buffering and logging lines with prefix.
> 3. The client log was fetched without decryption even with a matching
>    decryption key. This is fixed by factoring out the data blob
>    decryption logic into a reusable helper function and using it in
>    combination with the crypt config to decrypt the blobs while
>    fetching the client log.
> 
> [...]

Applied, thanks! Made two follow-ups though:

 ea86e2697 sync: pull: remove encrypted client log temp file after decrypt
 68668ba53 sync: pull: skip local client log fetch when source lacks one

[1/3] sync: fix client log fetching for local sync job
      commit: c456d58a4212173d050b0d5796bef65588bf86d7
[2/3] sync: use log sender for logging when fetching client log
      commit: 2d4d0bf6b14621ea0deb402221e31e8e18c1bf6b
[3/3] sync: decrypt client log on pull with matching decryption key
      commit: e5b191109222b1b8f3abbbd7d73633bd0b42df25




      parent reply	other threads:[~2026-04-25 19:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25 14:09 [PATCH proxmox-backup 0/3] fixup client log fetching and decryption Christian Ebner
2026-04-25 14:09 ` [PATCH proxmox-backup 1/3] sync: fix client log fetching for local sync job Christian Ebner
2026-04-25 14:09 ` [PATCH proxmox-backup 2/3] sync: use log sender for logging when fetching client log Christian Ebner
2026-04-25 14:09 ` [PATCH proxmox-backup 3/3] sync: decrypt client log on pull with matching decryption key Christian Ebner
2026-04-25 19:37 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177714584411.2472936.17244011036690851535.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal