From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH] ignore HUP before client connect on pty
Date: Wed, 22 Apr 2026 12:36:11 +0200 [thread overview]
Message-ID: <177685416973.4160149.10609105073916689257.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260422085520.959328-1-d.csapak@proxmox.com>
On Wed, 22 Apr 2026 10:52:46 +0200, Dominik Csapak wrote:
> Since debian trixie, the `login` tool timing changed and it always sends
> a HUP first thing. This caused spiceterm to immediately close again.
>
> To fix that, ignore all HUPs on the PTY side until at least one client
> is connected.
>
> To achieve that the client count is moved inside the SpiceScreen struct,
> since that is reachable from all callbacks needed
> (connect/disconnect/timeout/channel watcher).
>
> [...]
Applied, with a reference to the proxmox-termproxy fix [0] added, thanks!
[0]: https://git.proxmox.com/?p=pve-xtermjs.git;a=commitdiff;h=7b47cca8368e
[1/1] ignore HUP before client connect on pty
commit: c9f43f31f8ecb17224c059467d1b4f29f40fd5ec
prev parent reply other threads:[~2026-04-22 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 8:52 [PATCH] ignore HUP before client connect on pty Dominik Csapak
2026-04-22 8:55 ` Dominik Csapak
2026-04-22 10:03 ` Fiona Ebner
2026-04-22 10:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177685416973.4160149.10609105073916689257.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.