Re: [PATCH proxmox-backup v7 0/9] fixes #6195: add support for moving groups and namespaces

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On April 16, 2026 7:18 pm, Hannes Laimer wrote:
> Add support for moving backup groups and entire namespace subtrees to
> a different location within the same datastore.
> 
> Groups are moved with exclusive per-group and per-snapshot locking.
> For S3, objects are copied to the target prefix before deleting the
> source. Namespace moves process groups individually, deferring and
> retrying lock conflicts once, so partially failed moves can be
> completed with move-group.

I think the basic approach looks workable now, but there is still some
code duplication/refactoring that would make the whole thing nicer and
especially easier to maintain down the line..

I haven't taken a close look at the UI side of things yet though

> v7, thanks @Fabian and @Arthur!:
>  - allow moving into existing target namespaces
>  - merge groups with the same name when owner matches and source
>    snapshots are strictly newer than target snapshots
>  - lock and move snapshots in batches(512) to avoid FD exhaustion
>  - assert new-style locking upfront
>  - pre-create target group dir with source owner
>  - use remove_dir for source cleanup, log errors instead of swallowing
>  - rename 'new-ns' to 'target-ns', use dedicated POST endpoints
>    /move-group and /move-namespace
>  - relax move-group permissions: DATASTORE_PRUNE + ownership on
>    source, DATASTORE_BACKUP + ownership on target
>  - add max-depth, delete-source, and merge-group/merge-groups flags
>  - add docs section and online help link for move dialogs
>  - make ns and target-ns required in CLI, no need to keep the
>    empty -> root thing since this is new
> 
> v6, thanks @Fabian and @Dominik!:
>  - drop ns locks, lock everything directly, like we do for delete
>  - ui: disable prune for empty groups
>  - ui: dont render verification status for empty groups
> 
> v5, thanks @Chris!:
>  - lock dir instead of .ns-lock file
>  - improve cleanup of partially failed s3 moves
>  - ui: show empty groups, re-order actions, add context menu
>  - add cli commands for both ns and group moves
> 
> 
> 
> Hannes Laimer (9):
>   ui: show empty groups
>   datastore: add move-group
>   datastore: add move-namespace
>   docs: add section on moving namespaces and groups
>   api: add POST endpoint for move-group
>   api: add POST endpoint for move-namespace
>   ui: add move group action
>   ui: add move namespace action
>   cli: add move-namespace and move-group commands
> 
>  docs/storage.rst                            |  45 ++-
>  pbs-datastore/src/backup_info.rs            | 165 +++++++-
>  pbs-datastore/src/datastore.rs              | 422 +++++++++++++++++++-
>  src/api2/admin/datastore.rs                 | 109 +++++
>  src/api2/admin/namespace.rs                 |  99 ++++-
>  src/bin/proxmox_backup_manager/datastore.rs | 109 ++++-
>  www/Makefile                                |   2 +
>  www/OnlineHelpInfo.js                       |   4 +
>  www/datastore/Content.js                    | 161 ++++++--
>  www/form/NamespaceSelector.js               |  11 +
>  www/window/GroupMove.js                     |  56 +++
>  www/window/NamespaceMove.js                 | 126 ++++++
>  12 files changed, 1274 insertions(+), 35 deletions(-)
>  create mode 100644 www/window/GroupMove.js
>  create mode 100644 www/window/NamespaceMove.js
> 
> -- 
> 2.47.3
> 
> 
> 
> 
> 
>