From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3E72E1FF136 for ; Mon, 20 Apr 2026 14:33:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 14BC627E38; Mon, 20 Apr 2026 14:33:27 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: Re: [PATCH proxmox{,-backup} v6 00/15] fix #4182: concurrent group pull/push support for sync jobs Date: Mon, 20 Apr 2026 14:33:08 +0200 Message-ID: <177668823978.549863.9361905624511062597.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260417092621.455374-1-c.ebner@proxmox.com> References: <20260417092621.455374-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776688320030 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YFCPUEFUFLKU5R4DLXHDN6PFZXFBWPVF X-Message-ID-Hash: YFCPUEFUFLKU5R4DLXHDN6PFZXFBWPVF X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 17 Apr 2026 11:26:06 +0200, Christian Ebner wrote: > Syncing contents from/to a remote source via a sync job suffers from > low throughput on high latency networks because of limitations by the > HTTP/2 connection, as described in [0]. To improve, syncing multiple > groups in parallel by establishing multiple reader instances has been > suggested. > > This patch series implements the functionality by adding the sync job > configuration property `worker-threads`, allowing to define the > number of groups pull/push tokio tasks to be executed in parallel on > the runtime during each job. > > [...] Applied some of the preparatory patches, thanks! [02/15] tools: group and sort module imports commit: c7fe846a0f0c92594ce91f66e76361f9a2b2c1d3 [07/15] sync: pull: revert avoiding reinstantiation for encountered chunks map commit: 173059e31a9dbc7f463019cc92ade864d02af6ef [08/15] sync: pull: factor out backup group locking and owner check commit: 5e1e7bb0de424af1c6466dc750882cd11d9b1675 [09/15] sync: pull: prepare pull parameters to be shared across parallel tasks commit: 9213b1ed3fd9f5469b78cc2934f1dcebf13c8fc3 [12/15] sync: push: prepare push parameters to be shared across parallel tasks commit: f2843b84f9d2219ff7213691af7f263133a4b039 left the rest out for now, as at least the logging part still needs some improvements/rework to be really functional, and without functional logging enabling parallelism is a mess. I don't think there is that much missing anymore to pull this across the line though. Best regards, -- Fabian Grünbichler