From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 197811FF13C for ; Thu, 16 Apr 2026 15:43:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C7CC6E3D; Thu, 16 Apr 2026 15:43:13 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup] pbs-key-config: align fsync behavior when storing new/existing key Date: Thu, 16 Apr 2026 15:42:30 +0200 Message-ID: <177634694101.663260.5103535490301918294.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324100413.215443-1-c.ebner@proxmox.com> References: <20260324100413.215443-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776346880296 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: B3G6XVPM5ROXEUKEQANF5TXAXTBZSYH3 X-Message-ID-Hash: B3G6XVPM5ROXEUKEQANF5TXAXTBZSYH3 X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 24 Mar 2026 11:04:13 +0100, Christian Ebner wrote: > In case a key is stored by replacing the file contents, the file > contents are synced to disk as the corresponding flag is set for > proxmox-sys::fs::replace_file(). When creating a new file however, > fsync is never called. > > Align the behaviour by also calling fsync in case of storing the key > to a new file. > > [...] Applied, thanks! [1/1] pbs-key-config: align fsync behavior when storing new/existing key commit: 322ca18a4039fb92f0c99f2665e2a51272fa4e31 Best regards, -- Fabian Grünbichler