From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: applied: [PATCH proxmox-backup] config: lock guard: label BackupLockGuard by must_use attribute
Date: Thu, 16 Apr 2026 12:20:23 +0200 [thread overview]
Message-ID: <177633481246.409019.14612302632126981703.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260415083146.187139-1-c.ebner@proxmox.com>
On Wed, 15 Apr 2026 10:31:45 +0200, Christian Ebner wrote:
> The BackupLockGuard is used to store the open file descriptor of a
> flocked file. Once dropped, the file lock is release.
>
> Since not binding the BackupLockGuard to a variable will result in
> dropping of the struct and therefore immediate unlocking of the file,
> set the must_use attribute with a meaningful description to get
> clippy warnings for this.
>
> [...]
Applied, thanks!
[1/1] config: lock guard: label BackupLockGuard by must_use attribute
commit: 0ab2cc729e7e95f13b6d9a0b9caf174dd0d2d1c6
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
prev parent reply other threads:[~2026-04-16 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 8:31 Christian Ebner
2026-04-16 10:20 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177633481246.409019.14612302632126981703.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.