From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 918821FF142 for ; Tue, 07 Apr 2026 11:56:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4ED5F124D2; Tue, 7 Apr 2026 11:57:04 +0200 (CEST) Date: Tue, 07 Apr 2026 11:56:26 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: applied: [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v8 00/21] Generate frr config using jinja templates and rust types To: Gabriel Goller , Thomas Lamprecht References: <20260327150127.545193-1-g.goller@proxmox.com> <177471674432.3099145.14191595895230112822.b4-ty@proxmox.com> <98e30abf-505b-433c-b509-6173a44e57bf@proxmox.com> In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1775555676.7m5ulveesz.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775555724307 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SONBBZ3AUBAZLENJLBNOCLEYCFXNVT3E X-Message-ID-Hash: SONBBZ3AUBAZLENJLBNOCLEYCFXNVT3E X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On March 31, 2026 10:44 am, Gabriel Goller wrote: > On 31.03.2026 10:35, Thomas Lamprecht wrote: >> Am 31.03.26 um 10:28 schrieb Gabriel Goller: >> > Note that patch 10 is still in the approval queue! >>=20 >> ah true, let it through now; I had in mind that there was a discussion f= or >> skipping the vtysh test for now (or maybe Wolfgang just mentioned someth= ing >> offlist), so I did not miss it. >=20 > Hmm yeah I added it with v7 (I think), but afaics wolfgang reviewed it, s= o I > thought we can pull it in. >=20 > @Fabian maybe as well. via debcargo, anything requiring dev-deps will be moved to autopkgtests (which sbuild can run automatically post-build). if we go down that route, we need to ensure to really run those tests when building packages!