From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CEA571FF13A for ; Wed, 01 Apr 2026 13:48:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4B71C19057; Wed, 1 Apr 2026 13:48:29 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Lukas Wagner Subject: Re: [PATCH manager] api: backup: add return schema for backup jobs Date: Wed, 1 Apr 2026 13:47:00 +0200 Message-ID: <177504401807.2730483.184909672933706926.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327152015.394455-1-l.wagner@proxmox.com> References: <20260327152015.394455-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775044018712 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KNXOM7FL6OMYDGLRIU5X5BPITLFDMDDU X-Message-ID-Hash: KNXOM7FL6OMYDGLRIU5X5BPITLFDMDDU X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 27 Mar 2026 16:20:15 +0100, Lukas Wagner wrote: > The GET /cluster/backup and /cluster/backup/ endpoints were > missing a proper return value schema. The schema properties themselves > were copied from the POST call, but needed to be slightly adapted. > > - id is a pve-backup-jobid, since this is what was used before > - fleecing, performance and prune-backups are submitted as a property > string, but returned as a proper JSON object, so these needed to be > overridden from the base config that stems from pve-guest-common > - 'next-run' was added > > [...] Applied this now, but please see my other reply for potentially dropping dow and starttime completely here (which is IMO best done as follow-up), thanks! [1/1] api: backup: add return schema for backup jobs commit: 0e85aecd829f838c5eb41f7655502a492ba651bd