From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CD25D1FF137 for ; Tue, 31 Mar 2026 22:40:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5F6187784; Tue, 31 Mar 2026 22:40:44 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Hannes Laimer Subject: applied: [PATCH pve-network] sdn: controller: prevent invalid router-id generation from zero mac Date: Tue, 31 Mar 2026 22:39:36 +0200 Message-ID: <177498957430.465431.14444018712536402921.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260213063844.2486-1-h.laimer@proxmox.com> References: <20260213063844.2486-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774989551841 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.504 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WOCUVS6NRXG5QTY7FNQOFFYZ7BS5KSZA X-Message-ID-Hash: WOCUVS6NRXG5QTY7FNQOFFYZ7BS5KSZA X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 13 Feb 2026 07:38:44 +0100, Hannes Laimer wrote: > When a standard loopback interface is used, the retrieved MAC is > typically 00:00:00:00:00:00. This causes the router-id generation logic > to produce "0.0.0.0", which is an invalid BGP ID. > > Explicitly check for a zero MAC address and fail with a descriptive > error. > > [...] Applied, thanks! [1/1] sdn: controller: prevent invalid router-id generation from zero mac commit: 0a82e0779c680c87ab54f713fa22fb37797fc853