From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 229911FF143 for ; Sat, 28 Mar 2026 17:55:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DE7D87B06; Sat, 28 Mar 2026 17:55:23 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Gabriel Goller Subject: applied: [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v8 00/21] Generate frr config using jinja templates and rust types Date: Sat, 28 Mar 2026 17:55:13 +0100 Message-ID: <177471674432.3099145.14191595895230112822.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327150127.545193-1-g.goller@proxmox.com> References: <20260327150127.545193-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774716867701 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.136 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RLARXGLFYSHOLAH7MWNR3TEEZBSMGQPS X-Message-ID-Hash: RLARXGLFYSHOLAH7MWNR3TEEZBSMGQPS X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 27 Mar 2026 16:01:03 +0100, Gabriel Goller wrote: > Previously we generated the frr config using one big perl hash, where every > controller-plugin and zone-plugin would push their stuff. This is not pretty > and also tricky to unite with our new rust-based fabrics. Furthermore the only > way to edit or override the frr config is currently the frr.conf.local file, > which is merged with the perl-hash in a very janky manner, which has sprouted > numerous forum threads. The main problem with the frr.conf.local is the limited > control which the user has as to where the override or additional config gets > placed. There are also a few config overrides or additions to frr.conf.local > that are currently impossible or generate invalid frr config. > > [...] Applied the following parts, thanks! proxmox-ve-rs: [1/9] ve-config: firewall: cargo fmt commit: 5901f899a77eb853e02dfef33eac1b07f826e7b6 [2/9] frr: add proxmox-frr-templates package that contains templates commit: 7d912a192d070d7e68b1e6c00b70a9cad1256ad0 [3/9] ve-config: remove FrrConfigBuilder struct commit: 4712a934875e117144975b11d2b24f7185990adc [4/9] sdn-types: support variable-length NET identifier commit: c6c1be318e1f8941e31abf5580f25b519ee2dd12 [5/9] frr: add template serializer and serialize fabrics using templates commit: 1ca7bb01f6bd175c4b4496b7146bd13bc113a25d [6/9] frr: add isis configuration and templates commit: 4198f041b5f7c70a66f2c60885d3d3858946186b [7/9] frr: support custom frr configuration lines commit: 9cdffc5eab293455c075c17c3d21b28200a5d048 [8/9] frr: add bgp support with templates and serialization commit: 900291179b1c0ee12d67d8fbef429bbd7b97958b [9/9] frr: enable minijinja strict undefined behavior mode commit: e97efc0574479b9e7ca0a75147f65627dd34caf5 pve-rs: [1/1] sdn: add function to generate the frr config for all daemons commit: fd535fa7ac4f0e60c27c9d65e3671f28925be74a pve-network: [1/9] tests: use Test::Differences to make test assertions commit: 643035b4efcfa0789c14dba34fe32094f59c0d33 [2/9] test: add tests for frr.conf.local merging commit: dc01549375f8cefcd5395348c8d3810e20df8622 [3/9] test: bgp: add some various integration tests commit: 5aee219e95623361ddbfb69ef5ee5d19cb690bac [4/9] sdn: write structured frr config that can be rendered using templates commit: 4fbdddd2ec44e113f85a4219d0771f705e3d0c52 [5/9] sdn: remove duplicate comment line '!' in frr config commit: 3e69602adb5d21ce9a398f928da0285dcc154c41 [6/9] tests: rearrange some statements in the frr config commit: c39a4de36703a69053bf600d6482fadf3239a238 [7/9] sdn: adjust frr.conf.local merging to rust template types commit: 3f078fb093e5508bb97bfbb293c66ec4b3909147 [8/9] test: adjust frr_local_merge test for new template generation commit: eadea6619a27d24314e3fd10cc9c2001f3491123 [9/9] api: add dry-run endpoint for sdn apply to preview changes commit: b129fc148ffb03c6b78152a966f82cc06e2d46e2 Only missing bumping pve-network and the pve-manager patch.