From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 23AC11FF13C for ; Thu, 05 Mar 2026 12:21:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9429A606E; Thu, 5 Mar 2026 12:22:19 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com, Robert Obkircher Subject: partially-applied: [PATCH v1 proxmox-backup 00/11] fix various warnings Date: Thu, 5 Mar 2026 12:20:49 +0100 Message-ID: <177270964629.616099.10364687966170936138.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260226144033.211039-1-r.obkircher@proxmox.com> References: <20260226144033.211039-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772709676472 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.128 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.018 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.703 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1.386 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EH2NWU6XIRGEI7FBSY63H4Z3YAMH7F5K X-Message-ID-Hash: EH2NWU6XIRGEI7FBSY63H4Z3YAMH7F5K X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 26 Feb 2026 15:40:14 +0100, Robert Obkircher wrote: > The first 10 patches fix all clippy warnings expect the one about > future incompatibilities in the num-bigint-dig v0.8.4 depencency. > > The last patch is an attempt at fixing the compiler warnings about the > deprecated flock function, but I'm not sure if this is an acceptable > solution. > > [...] Applied all except 6 and 11, thanks! [01/11] datastore: remove allow(clippy::cast_ptr_alignment) attribute commit: bfcfadd945b09790d61a7488f46e4f0cd6a0ef28 [02/11] api: use checked_div for compression ratio calculation commit: db2e38a7829a6e05848d8e42ea74a65932dc647b [03/11] datastore+server: sort by key instead of using comparison functions commit: a4170cddbafd78598b3ca9527e7780c1f77826f6 [04/11] api: remove unnecessary ampersand to fix clippy warning commit: 25aab8374e6ed11ba46ed23d51e8487a021e8403 [05/11] bin: debug: use pattern match instead of is_some+unwrap commit: a46daf70d48a6d5084ab6ae8c8d6de985ceb9266 [06/11] bin: proxy: fix clippy warning about unnecesary use of find_map opted to instead allow the lint and add a TODO comment, less churn and easier to read that way IMHO [07/11] datastore: silence warning about too many arguments commit: ac2135f74a30c7299712d59471877015034be37e [08/11] client: catalog shell: avoid unnecessary block_on in async code commit: 6bdd577755c45681c5c561f7b95796ea1b3decba [09/11] client: catalog shell: combine multiple block_on calls into one commit: 3b017ac5ca4867b40db1c5950795936546a67ec1 [10/11] client: catalog shell: avoid unsafe transmute commit: acf2bb0f8bf9bcef21344833466fa96445a538a7 [11/11] tape: media catalog: use Flock wrapper instead of deprecated function (no commit info) replied to that one individually! Best regards, -- Fabian Grünbichler