From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6C5EE1FF139 for ; Tue, 24 Feb 2026 14:00:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D16A39DE8; Tue, 24 Feb 2026 14:00:55 +0100 (CET) Date: Tue, 24 Feb 2026 14:00:46 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH proxmox-widget-toolkit v2] fix #2685: ui: allow 4-bit mac_prefix suffix To: Moayad Almalat , pve-devel@lists.proxmox.com References: <20260224120536.141228-1-m.almalat@proxmox.com> In-Reply-To: <20260224120536.141228-1-m.almalat@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1771937549.cj4v6qhgpi.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771938034079 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.179 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.717 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.236 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CAXWE3RA67Z23WVQBP646X25TKYFTSMI X-Message-ID-Hash: CAXWE3RA67Z23WVQBP646X25TKYFTSMI X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: typo in the subject - a 4-bit prefix makes no sense ;) On February 24, 2026 1:05 pm, Moayad Almalat wrote: > Signed-off-by: Moayad Almalat > --- > src/Toolkit.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/src/Toolkit.js b/src/Toolkit.js > index d4e579b..39513b8 100644 > --- a/src/Toolkit.js > +++ b/src/Toolkit.js > @@ -72,7 +72,7 @@ Ext.apply(Ext.form.field.VTypes, { > MacAddressText: gettext('Example') + ': 01:23:45:67:89:ab', > =20 > MacPrefix: function (v) { > - return /^[a-f0-9][02468ace](?::[a-f0-9]{2}){0,2}:?$/i.test(v); > + return /^(?:[a-f0-9][02468ace](?::[a-f0-9]{2}){0,2}:?|[a-f0-9][0= 2468ace](?::[a-f0-9]{2}){2}:[a-f0-9])$/i.test(v); I think this is not quite correct - the [02468ace] part here is for only allowing unicast addresses, but that only applies to the first octet! the old regex allowed 1-3 octets (with the first octet always being restricted to not allow multicast), and you want to extend it to 4 octets AFAIU? that would simply require replacing the `{0,2}` with a `{0,3}`, I think? but note that the backend in PVE has the same checks and would need to be adapted as well.. > }, > MacPrefixMask: /[a-fA-F0-9:]/, > MacPrefixText: > --=20 > 2.47.3 >=20 >=20 >=20 >=20 >=20