From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B68C91FF138 for ; Wed, 18 Feb 2026 18:37:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0D4A22C4A; Wed, 18 Feb 2026 18:38:10 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dietmar Maurer Subject: applied: [RFC proxmox v3] schema: add CommaSeparatedList wrapper type for comma-separated values Date: Wed, 18 Feb 2026 18:32:36 +0100 Message-ID: <177143595094.4007478.17378474587478729188.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260214081021.2845579-1-dietmar@proxmox.com> References: <20260214081021.2845579-1-dietmar@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771436277755 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3DM2MRQWVHX24UPX5ZMCXM73PTIVPNIC X-Message-ID-Hash: 3DM2MRQWVHX24UPX5ZMCXM73PTIVPNIC X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 14 Feb 2026 09:10:20 +0100, Dietmar Maurer wrote: > Introduce a new CommaSeparatedList wrapper type that provides > schema-aware serialization and deserialization of comma-separated > values, similar to PropertyString but designed for list/array types. > > Key components: > - CommaSeparatedListSchema trait: Provides the static ARRAY_SCHEMA > required for (de)serialization (workaround for unstable generic > const items in Rust) > - CommaSeparatedList: A transparent Vec newtype with Deref/ > DerefMut implementations for ergonomic access > > [...] Applied, thanks! Note that I made some opinionated follow-up commits on top of this, the main visible change for you is making the module private and exporting CommaSeparatedList and Co directly at the top-level proxmox-schema lib. I also export PropertyString now for consitency, but kept that module public for the time being to avoid compilation errors. I also added a few more tests for edge cases, and there I uncovered that, unlike the module rust doc-comment suggested, validation is currently only done for deserialization, but not serialization. That is also the main reason for why I did not yet bump proxmox-schema, as it would be good to have a short in person discussion if that's really the behavior we want to have here. [1/1] schema: add CommaSeparatedList wrapper type for comma-separated values commit: a9fa19c4c7eb97b101add1bce8edcf21292dcc49