From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7C3A61FF139 for ; Tue, 10 Feb 2026 10:30:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5ED3E19E2F; Tue, 10 Feb 2026 10:31:03 +0100 (CET) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Maximiliano Sandoval Subject: applied: [pbs-devel] [PATCH proxmox] lang: Remove offsetof macro Date: Tue, 10 Feb 2026 10:26:20 +0100 Message-ID: <177071557651.2615881.2701665102943222231.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260126141215.401447-1-m.sandoval@proxmox.com> References: <20260126141215.401447-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770715775988 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 462MKSZHRYO7EADBNTZZPASYNG27UEL2 X-Message-ID-Hash: 462MKSZHRYO7EADBNTZZPASYNG27UEL2 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 26 Jan 2026 15:12:11 +0100, Maximiliano Sandoval wrote: > With rust 1.90 this will crash while running cargo test with > > $ RUST_BACKTRACE=1 cargo test > > null pointer dereference occurred > stack backtrace: > 0: __rustc::rust_begin_unwind > at /usr/src/rustc-1.90.0/library/std/src/panicking.rs:697:5 > 1: core::panicking::panic_nounwind_fmt::runtime > at /usr/src/rustc-1.90.0/library/core/src/panicking.rs:117:22 > 2: core::panicking::panic_nounwind_fmt > at /usr/src/rustc-1.90.0/library/core/src/intrinsics/mod.rs:2367:9 > 3: core::panicking::panic_null_pointer_dereference > at /usr/src/rustc-1.90.0/library/core/src/panicking.rs:311:5 > 4: rust_out::main::_doctest_main_proxmox_lang_src_lib_rs_71_0 > 5: rust_out::main > 6: core::ops::function::FnOnce::call_once > > [...] Applied, thanks! Note that I rewrote the commit message completely, as having a full ordinary rust backtrace with 90% being just the standard panic and unwind frame pointers is really not providing anything useful, OTOH., knowing that there is a built-in offset_of macro since rust 1.77, that there is no usage of our macro in our code anymore, and having some references to this lint changing from a warning to an error provides context and background that is good to know. [1/1] lang: Remove offsetof macro commit: 2c70b4c98a6f6c86755f97bae109bacd3c3b1703