From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0173B1FF138 for ; Wed, 04 Feb 2026 18:40:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 952971DC0A; Wed, 4 Feb 2026 18:40:38 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Maximiliano Sandoval Subject: applied: [PATCH proxmox-i18n v2 0/5] Fix formats of translated strings Date: Wed, 4 Feb 2026 18:37:25 +0100 Message-ID: <177022664202.822433.11697802703105334755.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260204134835.422155-1-m.sandoval@proxmox.com> References: <20260204134835.422155-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770226757557 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.147 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YF67VFMJDQMHB4FDNTWUBY4FDJHL5TAN X-Message-ID-Hash: YF67VFMJDQMHB4FDNTWUBY4FDJHL5TAN X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 04 Feb 2026 14:48:28 +0100, Maximiliano Sandoval wrote: > Fix translation which would produce errors at runtime when substituting > variables when formatting the string. Also adds a msgfmt --check make target. > > See commit messages. > > Differences from v1: > - Adds a check target to make > - Fix more strings > - Mark as fuzzy instead of marking as untranslated > - Reword commit messages > - Remove javascript-format flag from that one message > > [...] Applied, thanks! btw. gettext 0.26 shouldn't be that far out in debian anymore [0], once it'spackaged we could look into how much trouble backporting that version would be. Maybe we could add a small perl version of your wrong format check script and integrate that with the build system directly too. [0]: https://lists.debian.org/debian-devel/2026/02/msg00033.html [1/5] ja: remove second plural form commit: 99fb0e182756bb3b7c4224431df313828b4681ed [2/5] fix strings with wrong format commit: ed4a3ea148dbbacde0756e58a6901b5153a57719 [3/5] make: remove javascript-format flag from extracted strings commit: fdfe0a0d9b681b7240228f5bdf1c52fc47812bad [4/5] run make do_update commit: 00d492afa74fb338bdfcdecacfc006639693f4d3 [5/5] make: add check target commit: 7feb0cb41b0b186ffa3ffb56e721bffa96e6664f