From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D0F1C1FF13B for ; Tue, 13 Jan 2026 14:43:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7A3618275; Tue, 13 Jan 2026 14:43:33 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Daniel Kral Date: Tue, 13 Jan 2026 14:42:54 +0100 Message-ID: <176831164865.132583.8819684256163458584.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260112101728.162151-1-d.kral@proxmox.com> References: <20260112101728.162151-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768311735678 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH ha-manager] resources: assert ha resource has correct guest type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon, 12 Jan 2026 11:16:49 +0100, Daniel Kral wrote: > Otherwise a HA resource with the wrong guest type can be added to the HA > resources configuration, which will make its methods (start, shutdown, > migrate, ...) fail. > > This does not fixup existing HA resource entries with the wrong guest > type, but manual removal, e.g., through `ha-manager remove ` and > re-adding it correctly, is still possible. > > [...] Applied with Michael's R-b and T-b, thanks! I slightly changed the error message to resource 'ct:$vmid' - guest with ID $vmid is not a container just to avoid any potential for confusion (stating "ct:something is not a ct" can sound a bit off). [1/1] resources: assert ha resource has correct guest type commit: 18b3b0950c04a8aaeb1b6a406a13f437ac6e7792 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel