From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DB1D51FF13B for ; Tue, 13 Jan 2026 11:24:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A972D144BF; Tue, 13 Jan 2026 11:24:53 +0100 (CET) Date: Tue, 13 Jan 2026 11:24:48 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251211153835.180405-1-c.ebner@proxmox.com> In-Reply-To: <20251211153835.180405-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1768299738.9dh8t1peti.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768299846698 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 0/8] followups for garbage collection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On December 11, 2025 4:38 pm, Christian Ebner wrote: > This patch series contains some followup to the recently introduced > changes to phase 2 of garbage collection on s3 backed datastores [0] > and clenups for marker files during phase 3 [1], as well as some > refactoring of the chunk filename extension parsing and bad chunk > filename generation. > > The first patch introduces a dedicated struct for tracking objects > to be deleted from the s3 object store during phase 2, bundling the > length and age based deletion threshold logic to the list state. > > Subsequent patches rename and adapt the chunk store iterator to > optimize for regular chunk filenames and clearly distinguish chunks > by directory entry filename extension. > > Further, chunk extension parsing and bad chunk filename generation are > moved to be associated functions of the newly introduced `ChunkExt` > enum. > > Changes since version 1 (thanks @Fabian for comments): > - Rebased onto current master > - Followup patches for refactoring extension parsing and bad chunk > filename generation. a few more nits inline, but in general this already looks like a nice cleanup! > > [0] https://lore.proxmox.com/pbs-devel/2b637884-f6bd-434d-be00-fa4e9d9e2dcb@proxmox.com/T/ > [1] https://lore.proxmox.com/pbs-devel/1764145262.ycdoq9dzrx.astroid@yuna.none/T/ > > proxmox-backup: > > Christian Ebner (8): > GC: Move S3 delete list state and logic to a dedicated struct > chunk store: rename and limit scope for chunk store iterator > chunk store: invert chunk filename checks in chunk store iterator > chunk store: return chunk extension and check for used marker > chunk store: refactor chunk extension parsing into dedicated helper > datastore: move bad chunk touching logic to chunk store > chunk store: move next bad chunk path generator into dedicated helper > chunk store: move bad chunk filename generation into dedicated helper > > pbs-datastore/src/chunk_store.rs | 100 ++++++++++++++++---- > pbs-datastore/src/datastore.rs | 154 +++++++++++++++---------------- > 2 files changed, 161 insertions(+), 93 deletions(-) > > > Summary over all repositories: > 2 files changed, 161 insertions(+), 93 deletions(-) > > -- > Generated by git-murpp 0.8.1 > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel