From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id ADFC61FF179 for ; Wed, 10 Dec 2025 15:18:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2D2941DA78; Wed, 10 Dec 2025 15:18:51 +0100 (CET) MIME-Version: 1.0 In-Reply-To: <20251126133419.570874-1-c.ebner@proxmox.com> References: <20251126133419.570874-1-c.ebner@proxmox.com> From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= To: Christian Ebner , pbs-devel@lists.proxmox.com Date: Wed, 10 Dec 2025 15:18:37 +0100 Message-ID: <176537631743.371273.12867159169043875156@yuna.proxmox.com> User-Agent: alot/0.0.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765376319690 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, datastore.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] followups for garbage collection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" could you rebase this? patch #1 doesn't apply anymore.. Quoting Christian Ebner (2025-11-26 14:34:15) > This patch series contains some followup to the recently introduced > changes to phase 2 of garbage collection on s3 backed datastores [0] > and clenups for marker files during phase 3 [1]. > > The first patch introduces a dedicated struct for tracking objects > to be deleted from the s3 object store during phase 2, bundling the > length and age based deletion threshold logic to the list state. > > Subsequent patches rename and adapt the chunk store iterator to > optimize for regular chunk filenames and clearly distinguish chunks > by directory entry filename extension. > > [0] https://lore.proxmox.com/pbs-devel/2b637884-f6bd-434d-be00-fa4e9d9e2dcb@proxmox.com/T/ > [1] https://lore.proxmox.com/pbs-devel/1764145262.ycdoq9dzrx.astroid@yuna.none/T/ > > proxmox-backup: > > Christian Ebner (4): > GC: Move S3 delete list state and logic to a dedicated struct > chunk store: rename and limit scope for chunk store iterator > chunk store: invert chunk filename checks in chunk store iterator > chunk store: return chunk extension and check for used marker > > pbs-datastore/src/chunk_store.rs | 61 ++++++++++---- > pbs-datastore/src/datastore.rs | 132 ++++++++++++++++++------------- > 2 files changed, 121 insertions(+), 72 deletions(-) > > > Summary over all repositories: > 2 files changed, 121 insertions(+), 72 deletions(-) > > -- > Generated by git-murpp 0.8.1 > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel