From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6CA911FF17A for ; Tue, 9 Dec 2025 17:24:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0888188B5; Tue, 9 Dec 2025 17:25:38 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com, Yuki Sireneva Date: Tue, 9 Dec 2025 17:25:27 +0100 Message-ID: <176529752385.73664.7588456303046408829.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251205124802.334198-1-yuki.utk8g@gmail.com> References: <20251205124802.334198-1-yuki.utk8g@gmail.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765297529051 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH pve-xtermjs] Avoid allocating in `pre_exec` closure X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Fri, 05 Dec 2025 12:47:50 +0000, Yuki Sireneva wrote: > `Error::new` allocates memory (see [148971]). This is bad in > multi-threaded programs, which pve-xtermjs AFAIK is. If the fork occurs > while the allocator lock is held by another thread, deadlocks can occur, > since there's no one left in the new process to unlock the mutex. > I do not believe this is UB, and modern libc offer protections against > this issue, but this isn't POSIX-compliant and should preferably be > avoided. > > [...] Applied, thanks! [1/1] Avoid allocating in `pre_exec` closure commit: 41051f5a5e7bce513a6e0e31cacea44cab988391 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 07BB41FF17A for ; Tue, 9 Dec 2025 17:25:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6FE4088D0; Tue, 9 Dec 2025 17:25:38 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com, Yuki Sireneva Date: Tue, 9 Dec 2025 17:25:27 +0100 Message-ID: <176529752385.73664.7588456303046408829.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251205124802.334198-1-yuki.utk8g@gmail.com> References: <20251205124802.334198-1-yuki.utk8g@gmail.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765297529051 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [pbs-devel] [PATCH pve-xtermjs] Avoid allocating in `pre_exec` closure X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri, 05 Dec 2025 12:47:50 +0000, Yuki Sireneva wrote: > `Error::new` allocates memory (see [148971]). This is bad in > multi-threaded programs, which pve-xtermjs AFAIK is. If the fork occurs > while the allocator lock is held by another thread, deadlocks can occur, > since there's no one left in the new process to unlock the mutex. > I do not believe this is UB, and modern libc offer protections against > this issue, but this isn't POSIX-compliant and should preferably be > avoided. > > [...] Applied, thanks! [1/1] Avoid allocating in `pre_exec` closure commit: 41051f5a5e7bce513a6e0e31cacea44cab988391 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel