From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2A3EB1FF184 for ; Thu, 20 Nov 2025 15:51:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7EDA0B9C7; Thu, 20 Nov 2025 15:51:05 +0100 (CET) Date: Thu, 20 Nov 2025 15:50:34 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251120130342.248815-1-s.rufinatscha@proxmox.com> In-Reply-To: <20251120130342.248815-1-s.rufinatscha@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1763648414.krvw7wyolk.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763650206342 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 0/6] datastore: remove config reload on hot path X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On November 20, 2025 2:03 pm, Samuel Rufinatscha wrote: > Hi, > > [..] nit: this is getting a bit long ;) > > ## Patch summary > > [PATCH 1/6] partial fix #6049: config: enable config version cache for datastore > [PATCH 2/6] partial fix #6049: datastore: impl ConfigVersionCache fast path for lookups > [PATCH 3/6] partial fix #6049: datastore: use config fast-path in Drop > [PATCH 4/6] partial fix #6049: datastore: add TTL fallback to catch manual config edits > [PATCH 5/6] to add a reload flag to the config cache helper. > [PATCH 6/6] to only bump generation when the config digest changes. > > ## Changes from v2: > > Added: > - [PATCH 5/6]: Add a reload flag to the config cache helper. > - [PATCH 6/6]: Only bump generation when the config digest changes. please fold those into the existing version where they make sense, and include a per-patch changelog to know *what* changed ;) e.g., the digest part can already go into the first patch (if the generation bumping is also moved thre from patch #4), or into patch #4. the structural changes I suggested are missing, and I think the readability got worse as a result since v2, we now have six instances of checking whether there is some cache we are operating on or not.. I'll give more detailed feedback on the two new patches.. > > ## Maintainer notes > > No dependency bumps, no API changes and no breaking changes. > > Thanks, > Samuel > > [1] Bugzilla #6049: https://bugzilla.proxmox.com/show_bug.cgi?id=6049 > [2] cargo-flamegraph: https://github.com/flamegraph-rs/flamegraph > [3] Bugzilla #7017: https://bugzilla.proxmox.com/show_bug.cgi?id=7017 > > Samuel Rufinatscha (6): > partial fix #6049: config: enable config version cache for datastore > partial fix #6049: datastore: impl ConfigVersionCache fast path for > lookups > partial fix #6049: datastore: use config fast-path in Drop > partial fix #6049: datastore: add TTL fallback to catch manual config > edits > partial fix #6049: datastore: add reload flag to config cache helper > datastore: only bump generation when config digest changes > > pbs-config/src/config_version_cache.rs | 10 +- > pbs-datastore/Cargo.toml | 1 + > pbs-datastore/src/datastore.rs | 232 ++++++++++++++++++++----- > 3 files changed, 197 insertions(+), 46 deletions(-) > > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel