From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 332E11FF184 for ; Thu, 20 Nov 2025 14:09:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5310F8393; Thu, 20 Nov 2025 14:10:03 +0100 (CET) Date: Thu, 20 Nov 2025 14:09:56 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251120115243.311895-1-h.laimer@proxmox.com> In-Reply-To: <20251120115243.311895-1-h.laimer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1763644154.hvdkxonehx.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763644168280 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, verify.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup] verify: include namespace for group in log X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On November 20, 2025 12:52 pm, Hannes Laimer wrote: > Groups with the same name in different namespaces couldn't really be told > appart. This solves this by also printing the namespace of a group to the > log. > > This came up in support. > > Signed-off-by: Hannes Laimer > --- > not super sure about the formatting, didn't want to change the > : format we use a lot. don't log for snapshots as that > would potentially add a lot of output that doesn't add much information > > src/backup/verify.rs | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/backup/verify.rs b/src/backup/verify.rs > index 734c7b30..10f54c28 100644 > --- a/src/backup/verify.rs > +++ b/src/backup/verify.rs > @@ -500,8 +500,15 @@ impl VerifyWorker { > }; > > let snapshot_count = list.len(); > + let ns = group.backup_ns(); > + let ns_str = if ns.is_root() { > + "/".to_string() > + } else { > + ns.to_string() > + }; > info!( > - "verify group {}:{} ({} snapshots)", > + "verify group in '{}' - {}:{} ({} snapshots)", > + ns_str, when syncing, we log the namespace once at the start/end, should follow this approach here as well for consistency? nested namespace names can get quite long.. > self.datastore.name(), > group.group(), > snapshot_count > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel