From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1D8221FF184 for ; Thu, 20 Nov 2025 14:02:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1AA657A66; Thu, 20 Nov 2025 14:03:04 +0100 (CET) Date: Thu, 20 Nov 2025 14:02:26 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251120092742.97147-1-c.ebner@proxmox.com> In-Reply-To: <20251120092742.97147-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1763643621.a39agi4muz.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763643717545 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, proxy.pid, service.in] Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] etc: raise nofile soft limit for proxmox-backup-proxy X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On November 20, 2025 10:27 am, Christian Ebner wrote: > Since commit 86d5d073 ("GC: fix race with chunk upload/insert on s3 > backends"), per-chunk file locks are acquired during phase 2 of > garbage collection for datastores backed by s3 object stores. This > however means that up to 1000 file locks might be held at once, which > can result in the limit of open file handles to be reached. > > Therefore, bump the nolimit for the proxmox-backup-proxy in the systemd > service unit, while keeping the hard limit as defined in > /etc/systemd/system.conf. > > Signed-off-by: Christian Ebner > --- > Changes since version 1: > - Bumpt the limit directly in the systemd service unit > > etc/proxmox-backup-proxy.service.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/etc/proxmox-backup-proxy.service.in b/etc/proxmox-backup-proxy.service.in > index 7ca806aa4..52ad99356 100644 > --- a/etc/proxmox-backup-proxy.service.in > +++ b/etc/proxmox-backup-proxy.service.in > @@ -10,6 +10,7 @@ Type=notify > ExecStart=%LIBEXECDIR%/proxmox-backup/proxmox-backup-proxy > ExecReload=/bin/kill -HUP $MAINPID > PIDFile=/run/proxmox-backup/proxy.pid > +LimitNOFILE=4096:524288 this change is not quite identical to the previous one though ;) is 4k really enough? that means (not even) 4 GC runs, which could easily happen with many datastores? some sort of rationale why it's okay to do this would also be great, after all there is a reason the default limit is so low.. > Restart=on-failure > User=%PROXY_USER% > Group=%PROXY_USER% > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel