From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D8ACF1FF183 for ; Wed, 19 Nov 2025 14:55:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E798D483; Wed, 19 Nov 2025 14:55:39 +0100 (CET) Date: Wed, 19 Nov 2025 14:55:32 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251119131553.40703-1-c.ebner@proxmox.com> In-Reply-To: <20251119131553.40703-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1763559597.oxmveiwrkq.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763560505240 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] etc: provide and enable mount unit for /run/proxmox-backup X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On November 19, 2025 2:15 pm, Christian Ebner wrote: > Since the introduction of per-chunk file locks for datastores with s3 > backend, the inodes on the tmpfs backing /run/proxmox-backup might be > to limited, the kernel dynamically calculating the limit based on > available system memory [0]. To not limit the number of inodes, > provide a systemd mount unit to create a dedicated tmpfs for > /run/proxmox-backup and only enable this for now so it becomes > effective on reboot, since this cannot be safely started now. > > [0] https://docs.kernel.org/filesystems/tmpfs.html > > Fixes: https://forum.proxmox.com/threads/176228/ > Signed-off-by: Christian Ebner > --- > debian/postinst | 2 ++ > debian/proxmox-backup-server.install | 1 + > "etc/run-proxmox\\x2dbackup.mount" | 13 +++++++++++++ > 3 files changed, 16 insertions(+) > create mode 100644 "etc/run-proxmox\\x2dbackup.mount" > > diff --git a/debian/postinst b/debian/postinst > index 8b5e9bbed..0fddfbd99 100644 > --- a/debian/postinst > +++ b/debian/postinst > @@ -25,6 +25,8 @@ case "$1" in > fi > deb-systemd-invoke $_dh_action proxmox-backup.service proxmox-backup-proxy.service >/dev/null || true > > + systemctl enable run-proxmox\\x2dbackup.mount >/dev/null || true this is not needed, by virtue of installing the unit this is already handled by dh_installsystemd (which we override to only enable, but not start/restart units), which inserts the following into the postinst (and a corresponding snippet for puring the package into postrm): # Automatically added by dh_installsystemd/13.24.2 if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then # The following line should be removed in trixie or trixie+1 deb-systemd-helper unmask 'run-proxmox\x2dbackup.mount' >/dev/null || true # was-enabled defaults to true, so new installations run enable. if deb-systemd-helper --quiet was-enabled 'run-proxmox\x2dbackup.mount'; then # Enables the unit on first installation, creates new # symlinks on upgrades if the unit file has changed. deb-systemd-helper enable 'run-proxmox\x2dbackup.mount' >/dev/null || true else # Update the statefile to add new symlinks (if any), which need to be # cleaned up on purge. Also remove old symlinks. deb-systemd-helper update-state 'run-proxmox\x2dbackup.mount' >/dev/null || true fi fi # End automatically added section > + > if test -n "$2"; then > # FIXME: Remove in future version once we're sure no broken entries remain in anyone's files > if grep -q -e ':termproxy::[^@]\+: ' /var/log/proxmox-backup/tasks/active; then > diff --git a/debian/proxmox-backup-server.install b/debian/proxmox-backup-server.install > index d06f026cf..11dd037e8 100644 > --- a/debian/proxmox-backup-server.install > +++ b/debian/proxmox-backup-server.install > @@ -6,6 +6,7 @@ etc/proxmox-backup-daily-update.timer /usr/lib/systemd/system/ > etc/proxmox-backup-proxy.service /usr/lib/systemd/system/ > etc/proxmox-backup.service /usr/lib/systemd/system/ > etc/removable-device-attach@.service /usr/lib/systemd/system/ > +etc/run-proxmox\x2dbackup.mount /usr/lib/systemd/system/ > usr/bin/pmt > usr/bin/pmtx > usr/bin/proxmox-tape > diff --git "a/etc/run-proxmox\\x2dbackup.mount" "b/etc/run-proxmox\\x2dbackup.mount" > new file mode 100644 > index 000000000..f5fbe2eb4 > --- /dev/null > +++ "b/etc/run-proxmox\\x2dbackup.mount" > @@ -0,0 +1,13 @@ > +[Unit] > +Description=Mount tmpfs at /run/proxmox-backup > +Conflicts=umount.target > +Before=local-fs.target umount.target > + > +[Mount] > +Type=tmpfs > +What=tmpfs > +Where=/run/proxmox-backup might be good to have a comment here *why* we do nr_inodes=0 ;) > +Options=rw,nosuid,nodev,noexec,relatime,nr_inodes=0,mode=755,inode64 and the options here mean that /run/proxmox-backup is Access: (0755/drwxr-xr-x) Uid: ( 0/ root) Gid: ( 0/ root) instead of the previous 755 but owned by backup:backup, so we need to also include uid and gid backup in the mountoptions here, else the proxy will fail to start after a reboot.. > + > +[Install] > +WantedBy=local-fs.target > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel