From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C449E1FF187 for ; Tue, 18 Nov 2025 17:31:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4D8A61AF23; Tue, 18 Nov 2025 17:31:18 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Stoiko Ivanov Date: Tue, 18 Nov 2025 17:31:08 +0100 Message-ID: <176348346455.1411996.16895562409267508595.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251118151532.592423-1-s.ivanov@proxmox.com> References: <20251118151532.592423-1-s.ivanov@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763483445421 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH installer 0/2] nic pinning: require first character to be lower-case X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, 18 Nov 2025 16:15:25 +0100, Stoiko Ivanov wrote: > The regex for validating NICs in pve-common starts with /^[a-z].../ > getting 'name must start with a letter' to a pinned nic-name of 'ABC' is > confusing. Additionally there was a discrepancy in validating the nic-name > in the rust-based installers (is_ascii_alphabetic also matches upper-case > letters, whereas the perl-regex required [a-z]) > > Align the validation with the version in pve-common. > > [...] Applied, thanks! [1/2] common: pinning: require first character to be lower-case ascii commit: 47700a50ab4a8e3322aaa69f6a7ea584519b98e5 [2/2] sys: net: fix error-message for interface names first character commit: fc9e72091861b0f0981c8a4153c4017839478af7 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel