From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DCB2F1FF185 for ; Mon, 17 Nov 2025 15:19:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D9A71AF34; Mon, 17 Nov 2025 15:19:13 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Filip Schauer Date: Mon, 17 Nov 2025 15:15:45 +0100 Message-ID: <176338894275.3640252.15864259508521949438.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251117124935.126982-1-f.schauer@proxmox.com> References: <20251117124935.126982-1-f.schauer@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763389090671 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [docker.io] Subject: [pve-devel] applied: [PATCH container] config: allow empty environment variables X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon, 17 Nov 2025 13:49:03 +0100, Filip Schauer wrote: > This fixes a problem with the docker.io/httpd OCI image which specifies > an empty environment variable. This violated the pattern of the `env` > property, causing `pct config ` to fail with: > ``` > env: value does not match the regex pattern > ``` > > [...] I actually wondered about that and had the frontend "allowBlank" check initially such that the value was only required if the name field was set (as the variable simply gets deleted otherwise), but I then changed it to both to be required, as allowing something more is almost always easier to do in the future compared to restricting it, especially if it involves API exposed schema. Anyhow, the UI part would need now also adaption to make your change fully work also there. Applied, thanks! [1/1] config: allow empty environment variables commit: 9a5f5ce5cfdbc85b2d40a4a20662065d18b85f6c _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel