From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 728FD1FF187 for ; Mon, 17 Nov 2025 10:30:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3026B11BFF; Mon, 17 Nov 2025 10:30:40 +0100 (CET) Date: Mon, 17 Nov 2025 10:30:32 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251117085813.11797-1-h.laimer@proxmox.com> In-Reply-To: <20251117085813.11797-1-h.laimer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1763371276.pn35dnj8x0.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763371806151 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, task.pid] Subject: Re: [pbs-devel] [PATCH proxmox-backup] task tracking: improve pruning of reused-PID stale entries X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On November 17, 2025 9:58 am, Hannes Laimer wrote: > Keep entries only when check_process_running(pid) reports a > starttime equal to the stored one. This improves pruning of stale > entries for all PIDs (not just the current one) and aligns update > with the read path. Counting behavior and semantics are unchanged. I don't think this is correct? the starttime comparison is only valid for the current process, an old process will almost certainly have a different starting time and we still want to keep its entry if it is still running.. if we want to improve this, we would need to query the process starttime for all entries, and then compare, but that would make this more expensive.. > > Signed-off-by: Hannes Laimer > --- > noticed while looking through recent proposed changes to the tracking > logic. this isn't a problem, but should keep the tracking file cleaner > and remove a match arm in the code > > pbs-datastore/src/task_tracking.rs | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/pbs-datastore/src/task_tracking.rs b/pbs-datastore/src/task_tracking.rs > index 44a4522d..4fcbbaa4 100644 > --- a/pbs-datastore/src/task_tracking.rs > +++ b/pbs-datastore/src/task_tracking.rs > @@ -114,8 +114,7 @@ pub fn update_active_operations( > .iter_mut() > .filter_map( > |task| match procfs::check_process_running(task.pid as pid_t) { > - Some(stat) if pid == task.pid && stat.starttime != task.starttime => None, > - Some(_) => { > + Some(stat) if stat.starttime == task.starttime => { > if pid == task.pid { > found_entry = true; > match operation { > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel