From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 868DB1FF17E for ; Thu, 13 Nov 2025 13:52:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9BCD61B418; Thu, 13 Nov 2025 13:53:35 +0100 (CET) Date: Thu, 13 Nov 2025 13:53:28 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251113093118.195229-1-n.frey@proxmox.com> In-Reply-To: <20251113093118.195229-1-n.frey@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1763030636.kcagc316qr.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763038385874 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v4 00/12] parallelize chunk reads in verification X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Gave this a spin as well, the code looks good to me and adding more threads does make things faster, although finding the best combination is probably a bit tricky: 1:4 90s (baseline) 1:8 91s (verify threads were already not fully utilized in the baseline) 4:4 46s 2:6 58s these were with a smaller set of snapshots and a warm cache. with a full datastore that doesn't fit into RAM/cache: 1:4 408s 1:8 349s 4:4 159s 2:6 204s adding more threads mostly does not help anymore in my case.. On November 13, 2025 10:31 am, Nicolas Frey wrote: > This patch series aims to expand on Dominik's series [0] written for > pbs 3, parallelizing chunk reads in `VerifyWorker` using a seperate > thread pool from the verification. > > The number of threads was previously hard-coded, but is now > configurable via the API and GUI with new properties called > `{read,verify}-threads`, similarly to tape backups. > > The number of threads should also be configurable through tuning > options or datastore config (as discussed by Chris & Thomas on list), > which can be added in a follow up patch series. > > In my local tests I measured the following speed difference: > verified a single snapshot with ~32 GiB (4x the RAM size) with 4 > cores (just changing the read threads) > > 1 thread: ~440MiB/s > 2 threads: ~780MiB/s > 4 threads: ~1140MiB/s > > [0] https://lore.proxmox.com/pbs-devel/20250707132706.2854973-1-d.csapak@proxmox.com/#t > > Changes since v3, thanks Chris!: > * correct the ordering of patches > * move thread schemas into jobs.rs, rename them and add more specific > descriptions > * add api schema for {read,verify}-threads in backup manager > * add doc for new parameters > * rebase > > Changes since v2: > * split move to parallel handler into 2 seperate commits > * add constructor to `IndexVerifyState` and clean up nits > > Changes since v1, thanks to Chris: > * define dedicated schema for {worker,read,verify}-threads > * rebase proxmox-backup > * introduce new state struct `IndexVerifyState` to reduce the amount > of Arc clones and overall better bundling > * adjust update endpoint and UI to the new properties > > proxmox: > > Nicolas Frey (3): > pbs-api-types: add schema for {worker,read,verify}-threads > pbs-api-types: jobs: add {read,verify}-threads to > VerificationJobConfig > pbs-api-types: use worker-threads schema for TapeBackupJobSetup > > pbs-api-types/src/jobs.rs | 41 ++++++++++++++++++++++++++++++++++----- > 1 file changed, 36 insertions(+), 5 deletions(-) > > > proxmox-backup: > > Nicolas Frey (9): > verify: correct typo in comment > verify: introduce new state struct > verify: refactor into associated functions to use new state struct > verify: move chunk loading into parallel handler > verify: determine the number of threads to use with > {read,verify}-threads > verify: add {read,verify}-threads to update endpoint > verify: add {read,verify}-threads to api schema in backup manager > ui: verify: add option to set number of threads for job > docs: verify: document {read,verify}-threads and update screenshot > > .../pbs-gui-datastore-verifyjob-add.png | Bin 15455 -> 41433 bytes > docs/maintenance.rst | 11 +- > src/api2/admin/datastore.rs | 16 +- > src/api2/backup/environment.rs | 4 +- > src/api2/config/verify.rs | 16 ++ > src/backup/verify.rs | 171 +++++++++++------- > src/bin/proxmox-backup-manager.rs | 11 +- > src/server/verify_job.rs | 7 +- > www/window/VerifyAll.js | 18 ++ > www/window/VerifyJobEdit.js | 24 +++ > 10 files changed, 210 insertions(+), 68 deletions(-) > > > Summary over all repositories: > 11 files changed, 246 insertions(+), 73 deletions(-) > > -- > Generated by git-murpp 0.8.1 > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel