From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5DF3A1FF17A for ; Tue, 11 Nov 2025 14:56:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 76D60B5C4; Tue, 11 Nov 2025 14:57:42 +0100 (CET) Date: Tue, 11 Nov 2025 14:57:05 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251029110625.375975-1-c.ebner@proxmox.com> In-Reply-To: <20251029110625.375975-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1762869260.4x95zysxo6.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762869405073 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/2] fix 2 issues with s3 store verifies X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" although that nested match there would benefit from some refactoring, and I am also not 100% sure we shouldn't add some additional checks to the flow there (e.g., heal the S3 chunk if the local one is correct, verify the local one is correct in addition to the S3 one, ensure renaming happens even if either side is missing the "corrupt" chunk?) On October 29, 2025 12:06 pm, Christian Ebner wrote: > This patches were pulled out from the original patch series [0] since > they are independent from the bigger series attempting to fix the > possible race between corrupt chunk renaming and chunk insert/upload > and better reviewed/tested independently. > > Patch 1 makes sure the mutex guard to sync up access to the corrupt > chunk list is dropped before attempting to rename a corrupt chunk, > which will call into async context on s3 stores. Otherwise deadlock > can arise. > > Patch 2 is a followup to the bugfix for issue #6665, which however > did not correctly distinguish between transient fetching errors and > the possible chunk DataBlob decoding error from the response body in > case of a successful response. > > [0] https://lore.proxmox.com/pbs-devel/20251016131819.349049-6-c.ebner@proxmox.com/T/ > > Christian Ebner (2): > verify: never hold mutex lock in async scope on corrupt chunk rename > verify: distinguish s3 object fetching and chunk loading error > > src/backup/verify.rs | 34 +++++++++++++++++++--------------- > 1 file changed, 19 insertions(+), 15 deletions(-) > > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel