From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7A39A1FF179 for ; Wed, 29 Oct 2025 14:34:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1A462B1EA; Wed, 29 Oct 2025 14:35:23 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Date: Wed, 29 Oct 2025 14:34:38 +0100 Message-ID: <176174487456.1745550.17820385626740320723.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251029131256.3124803-1-d.csapak@proxmox.com> References: <20251029131256.3124803-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761744877025 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager v2] ui: properly reset API 401 count X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed, 29 Oct 2025 14:12:40 +0100, Dominik Csapak wrote: > due to a timing race condition, it can happen that we try to increase > the 401 count before resetting it (which happens after the first > ticket api call). Since `undefined + ` === NaN, our later check for > `> 5` never triggers and we don't show the login mask, but an empty > window. > > To fix this, initialize the variable always with 0. > > [...] Applied with Fiona's R-b, thanks! [1/1] ui: properly reset API 401 count commit: 566412124a846f42420e013e5191224d4bd88c61 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel