From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AFC991FF1CC for ; Mon, 27 Oct 2025 11:59:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B40EF1FA2; Mon, 27 Oct 2025 12:00:08 +0100 (CET) Date: Mon, 27 Oct 2025 11:59:31 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251016131819.349049-1-c.ebner@proxmox.com> <20251016131819.349049-5-c.ebner@proxmox.com> In-Reply-To: <20251016131819.349049-5-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1761561665.wld02i9uco.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761562763831 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 4/6] datastore: acquire chunk store mutex lock when renaming corrupt chunk X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On October 16, 2025 3:18 pm, Christian Ebner wrote: > While the rename itself is an atomic operation, it must be assured > that no other task such as garbage collection or backup chunk insert > are expecting to hold an exclusive access to the chunk store. > > Signed-off-by: Christian Ebner > --- > pbs-datastore/src/datastore.rs | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs > index c280b82c7..a7ea8fd96 100644 > --- a/pbs-datastore/src/datastore.rs > +++ b/pbs-datastore/src/datastore.rs > @@ -2465,6 +2465,8 @@ impl DataStore { > )?; > } > > + let _lock = self.inner.chunk_store.mutex().lock().unwrap(); > + the counter/new_path loop should move here to also be protected by the lock - it doesn't buy as much, but it's better than nothing.. but it's also used for S3, without anything ensuring that the counters are actually in sync between those two? > match std::fs::rename(&path, &new_path) { > Ok(_) => Ok(Some(format!("corrupted chunk renamed to {new_path:?}"))), > Err(err) if err.kind() == std::io::ErrorKind::NotFound => Ok(None), > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel