From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 984151FF191 for ; Tue, 21 Oct 2025 20:34:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D9907179; Tue, 21 Oct 2025 20:35:01 +0200 (CEST) From: Thomas Lamprecht To: pmg-devel@lists.proxmox.com, Dominik Csapak Date: Tue, 21 Oct 2025 20:33:12 +0200 Message-ID: <176107158740.2116219.11884107450001498577.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251015142310.3633830-2-d.csapak@proxmox.com> References: <20251015142310.3633830-1-d.csapak@proxmox.com> <20251015142310.3633830-2-d.csapak@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761071660342 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] applied: [PATCH proxmox 1/1] login: fix userid check for '@quarantine' user tickets X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" On Wed, 15 Oct 2025 16:22:58 +0200, Dominik Csapak wrote: > when logging into the pmg quarantine via LDAP, the user typically > enters a userid like 'foo@bar.com'. When receiving a valid ticket, > this contains a userid like 'foo@bar.com@quarantine'. To check if that's > correct, use our helper instead of manually checking for equality. > > That helper also needs fixing: while it should be (optionally) possible > to enter the username with 'foo@bar.com@quarantine' (so we have to strip > the quarantine part from the expected userid), we also have to strip the > '@quarantine' part from the ticket response, since it contains that too. > > [...] Applied, with some actual unit tests added as follow-up as rust makes doing that so easy that it's hard to argue for not having them, thanks! [1/1] login: fix userid check for '@quarantine' user tickets commit: 7e23aa421fa5d7177fd2ff58d6d217ab6e7c8d80 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel