From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BAB9D1FF17E for ; Thu, 2 Oct 2025 14:18:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 14233E67C; Thu, 2 Oct 2025 14:19:02 +0200 (CEST) Date: Thu, 02 Oct 2025 14:18:24 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20251002091142.222897-1-c.ebner@proxmox.com> <20251002091142.222897-3-c.ebner@proxmox.com> In-Reply-To: <20251002091142.222897-3-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1759407371.2x17nfaxte.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759407484288 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] datastore: gc: rename method and adapt incorrect comments X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On October 2, 2025 11:11 am, Christian Ebner wrote: > ss the helper does not really mark the chunks but rather checks > if it should be added to the delete list. > > Signed-off-by: Christian Ebner > --- > pbs-datastore/src/datastore.rs | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs > index 2e62590f9..b76bb1987 100644 > --- a/pbs-datastore/src/datastore.rs > +++ b/pbs-datastore/src/datastore.rs > @@ -1654,7 +1654,7 @@ impl DataStore { > > for content in list_bucket_result.contents { > if self > - .mark_chunk_for_object_key( > + .check_chunk_marker_for_object_key( > &content.key, > content.size, > min_atime, > @@ -1796,10 +1796,9 @@ impl DataStore { > Ok(()) > } > > - // Mark the chunk marker in the local cache store for the given object key as in use > - // by updating it's atime. > - // Returns Ok(true) if the chunk was updated and Ok(false) if the object was not a chunk. > - fn mark_chunk_for_object_key( > + // Check if the chunk marker in the local cache store for the given object key marks the chunk > + // object as in-use or adds it to the list of objects to delete. > + fn check_chunk_marker_for_object_key( this is still wrong - this method doesn't mark anything as in-use, but it does remove it from the cache (if eligible), which will also remove the cache marker! so either we really make this a pure check helper (and let it return whether the corresponding digest should be removed from the cache?) or we find some better name ;) > &self, > object_key: &S3ObjectKey, > size: u64, > -- > 2.47.3 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel