From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 659431FF16B for ; Fri, 26 Sep 2025 12:50:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA1D0D9E3; Fri, 26 Sep 2025 12:51:17 +0200 (CEST) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, Dominik Csapak Date: Fri, 26 Sep 2025 12:47:57 +0200 Message-ID: <175888367274.3582401.2741606156308428063.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250926072017.558000-1-d.csapak@proxmox.com> References: <20250926072017.558000-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758883829513 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 1/4] ui: pve: storage: clippy fix X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Fri, 26 Sep 2025 09:20:05 +0200, Dominik Csapak wrote: > unnecessary reference, after we remove that, it's an unnecessary closure > > Applied, thanks! I reworded the commit message though, as especially the one from patch 3/4 was misleading (fixes status update not rrd update). Also made a follow-up to change the name of the timeout update reference guards to not start with an underscore, as then we would have noticed this earlier. We should avoud rework other code sides using this problematic pattern too, not sure if the "_guard" prefix is the best one ("_holder" might be an alternative), but it's semantically true enough and we can change that still. [1/4] ui: pve: storage: clippy fix commit: cf90529e6d250dd4113db3884efc8ce46c02699c [2/4] ui: pve: storage: remove unnecessary import commit: f8c9d3db5cd51dfff92384379f764a0710c29ab7 [3/4] ui: pve: storage: fix rrd update commit: c515d324ba077625b0f15ccf08c878bc97fdb12e [4/4] ui: pve: storage: remove unnecessary 'enabled' status line commit: e8be46072ead4e53dd3cec04bc26ed90642dcffd _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel