From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D15561FF187 for ; Mon, 22 Sep 2025 20:06:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EAA7F219D8; Mon, 22 Sep 2025 20:06:37 +0200 (CEST) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, Christian Ebner Date: Mon, 22 Sep 2025 19:59:15 +0200 Message-ID: <175856395265.2589959.1367040706510831448.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250922110958.369653-1-c.ebner@proxmox.com> References: <20250922110958.369653-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758564381978 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.152 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] applied-series: [PATCH datacenter-manager 0/6] ui/api: implement and expose adding PBS remotes via the ui wizard X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On Mon, 22 Sep 2025 13:09:52 +0200, Christian Ebner wrote: > While it is already possible to add PBS remote via the cli, the UI currently > does not expose this functionality. Most of the required pieces are however > already there, so implement the missing api endpoints to check the TLS > connection and scan the remote for the PDM api and add the required methods to > the PDM client. > > Finally, make sure the correct PDM implementation for PBS is used based on the > remote type as stored in the remote add wizard state and expose the button > to add the PBS instance. > > [...] Applied, thanks! btw. some pre-existing things that I noticed with the remote add wizard, certainly do not have to be fixed by you, just wanted to jot them down before I forget them. Anyway: - One can use a full URL with https:// and trailing slash and the probe will work fine, but on the final step of the wizard one will get an error about a invalid character in the URL. Would be great if this works (or does not work) consistently for probing and actual usage; e.g. by stripping default protocol, single trailing slash or default port (or whatever is required to make it work). - after going back just to edit the URL the whole wizard gets reset, that is not really that nice. It's not a trivial thing to solve in an always correct way, so maybe ask the user about wanting to reset the wizard? But IMO most of the time all data one entered was entered with the intend for it to actually be correct, so fixing small typos should probably not reset anything by default, as what's the upside here? A compromis might be to deactivate the next steps but retain the values, that way all intra-step checks will be executed but an user does not needs to re-enter information. - The URL won't be updated when going back from the summary page of the wizard to the first and changing it. At least the same old value was rendered in the summary and when then going back again to the first step the outdated value was again shown there too (and I got the error from the backend, but did not check if the same was actually send, might have had another "error" in the URL). [1/6] server: api: add TLS probe endpoint for PBS commit: 239d0eb0cb13eac72686e6c337eb328e8bd0182c [2/6] pdm-client: add method to probe TLS connection for PBS remotes commit: a9837ef08c1082dd6d282dadafd35144b97ddc63 [3/6] server: api: implement endpoint to scan remote PBS instances commit: bdb844b271e8397b0346a66f4bf8d1d877f402d3 [4/6] pdm client: add method to scan remote PBS instances commit: 645a92d5d6fd0817b059c2a7197be20506e8c1be [5/6] ui: remote: check connection for PBS remotes in remote add wizard commit: 6ce9dcad2b8ec7eb218ce41e18f8942d02dfa3ef [6/6] ui: reorganize remote add button as dropdown menu to allow adding PBS commit: 62a96d23363b8fc6fb2342dd868a8a76f1aab937 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel