From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EB9E31FF16F for ; Tue, 16 Sep 2025 12:10:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A8D00FF19; Tue, 16 Sep 2025 12:10:46 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Gabriel Goller Date: Tue, 16 Sep 2025 12:10:03 +0200 Message-ID: <175801740046.1062983.11034703970346131532.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250911153359.278834-1-g.goller@proxmox.com> References: <20250911153359.278834-1-g.goller@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758017405741 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH network] frr: print task warning when frr reload fails X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu, 11 Sep 2025 17:33:54 +0200, Gabriel Goller wrote: > Instead of just printing a normal warning, use log_warn, which adds a > warning to the whole task. This means the whole task ends with a > "warning" status which is visible nicely in the task list. Previously we > just printed a warning, which made the task end with "OK" even if the > reload failed. > > frr-reload.py only fails if it's not installed (where a warning status > is ok) or the configuration is not valid (where a warning status is also > ok). Having frr-reload.py uninstalled for some reason and always relying > on `systemctl restart frr` to reload the sdn config is kinda weird and > you probably deserve to get a warning on each sdn apply task. > > [...] Applied, thanks! [1/1] frr: print task warning when frr reload fails commit: ea13baa9af4cff1c2dbc096a757b4c0a94afaa56 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel