From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9E23C1FF183 for ; Wed, 13 Aug 2025 09:47:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 76C6B1D90B; Wed, 13 Aug 2025 09:49:28 +0200 (CEST) Date: Wed, 13 Aug 2025 09:48:51 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20250812164631.428424-1-m.carrara@proxmox.com> <20250812164631.428424-2-m.carrara@proxmox.com> In-Reply-To: <20250812164631.428424-2-m.carrara@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1755071263.mdzx9t83o2.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755071302957 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [osd.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH pve-manager master v1 1/2] fix #6652: ceph: osd: enable autoactivation for OSD LVs on creation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On August 12, 2025 6:46 pm, Max R. Carrara wrote: > ... by directly calling lvcreate instead of using the LVM storage > plugin's helper sub. > > Autoactivation is required for LVs used by Ceph OSDs, as Ceph > otherwise doesn't activate them by itself. > > This is a regression from f296ffc4e4d in pve-storage [0]. > > [0]: https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=f296ffc4e4d64b574c3001dc7cc6af3da1406441 > > Fixes: #6652 > Signed-off-by: Max R. Carrara > --- > PVE/API2/Ceph/OSD.pm | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm > index 23e187ce..4801f8dd 100644 > --- a/PVE/API2/Ceph/OSD.pm > +++ b/PVE/API2/Ceph/OSD.pm > @@ -443,7 +443,25 @@ __PACKAGE__->register_method({ > my $lv = $type . "-" . UUID::uuid(); > > PVE::Storage::LVMPlugin::lvm_create_volume_group($dev->{devpath}, $vg); > - PVE::Storage::LVMPlugin::lvcreate($vg, $lv, "${size}k"); > + > + my $cmd = [ > + '/sbin/lvcreate', > + '-aly', > + '-Wy', > + '--yes', > + '--size', > + # size in kilobytes > + $size . "k", > + '--name', > + $lv, > + # explicitly enable autoactivation, > + # otherwise ceph-volume cannot bring the LV online > + '--setautoactivation', > + 'y', > + $vg, > + ]; > + > + run_command($cmd, errmsg => "lvcreate '$vg/$lv' error"); there's a second call to PVE::Storage::LVMPlugin::lvcreate a few lines below, is that not also problematic? > > if (PVE::Diskmanage::is_partition($dev->{devpath})) { > eval { PVE::Diskmanage::change_parttype($dev->{devpath}, '8E00'); }; > -- > 2.47.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel