From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6A30D1FF16F for ; Tue, 5 Aug 2025 12:20:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1A378BFBB; Tue, 5 Aug 2025 12:21:35 +0200 (CEST) MIME-Version: 1.0 In-Reply-To: <20250805100556.40874-1-f.ebner@proxmox.com> References: <20250805100556.40874-1-f.ebner@proxmox.com> From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= To: Fiona Ebner , pve-devel@lists.proxmox.com Date: Tue, 05 Aug 2025 12:20:57 +0200 Message-ID: <175438925746.266911.16254321466643248081@yuna.proxmox.com> User-Agent: alot/0.0.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754389241871 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] d/tmpfiles: fix permission regression for /run/pve directory X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Quoting Fiona Ebner (2025-08-05 12:03:24) > There is a regression regarding the permission for the /run/pve > directory. In Proxmox VE 8, the directory had root:root 0755 > permissions, being auto-created as the lxc-syscalld runtime directory. > In Proxmox VE 9, the permissions were restricted to root:root 0750, > but this leads to an issue with remote migration, when pveproxy tries > to access the mtunnel socket: > > pveproxy[2484]: connect to 'unix/:/run/pve/ct-112.mtunnel' failed: Permission denied > > Relax the permissions again by allowing the www-data group > read-access, so that pveproxy can access the socket. > > This aligns the permissions with what /run/pve-cluster has. > > Reported-by: Hannes Laimer > Signed-off-by: Fiona Ebner > --- > debian/tmpfiles | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/debian/tmpfiles b/debian/tmpfiles > index 98b8fb96..1263300f 100644 > --- a/debian/tmpfiles > +++ b/debian/tmpfiles > @@ -1,2 +1,2 @@ > -#Type Path Mode User Group Age Argument > -d /run/pve 0750 root root - - > +#Type Path Mode User Group Age Argument > +d /run/pve 0750 root www-data - - > -- > 2.47.2 the change itself LGTM, but note that pve-manager is lacking #DEBHELPER# in debian/postinst, so the snippet that ensures the dir gets created at package installation/upgrade time is missing. FTR, the snippet looks like this: # Automatically added by dh_installtmpfiles/13.24.2 if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then if [ -x "$(command -v systemd-tmpfiles)" ]; then systemd-tmpfiles ${DPKG_ROOT:+--root="$DPKG_ROOT"} --create pve-manager.conf || true fi fi the tmpfiles config above is also lacking `z` which would ensure that the changed ownership actually is set on upgrades, as opposed to on the next reboot? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel