[pbs-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config

[pbs-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config

[Christian Ebner]

Commit 691f530d ("network: optionally show alternative interface
names") introduced the optional altnames field in the network edit
grid. The chosen default configuration however does not even add the
field, therefore setting it to hidden if no altnames data is present
cannot work.

Fix this by only hiding the field if it was actually configured to be
shown in the first place.

Fixes: 691f530d ("network: optionally show alternative interface names")
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/node/NetworkEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index cd9dc7c..601d788 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -465,7 +465,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
                         if (Ext.isArray(data.altnames)) {
                             data.altnames = data.altnames.join('<br>');
                         }
-                    } else {
+                    } else if (me.showAltNames && !me.isCreate) {
                         me.down('field[name=altnames]').setVisible(false);
                     }
                     me.setValues(data);
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pve-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config

[Christian Ebner]

Commit 691f530d ("network: optionally show alternative interface
names") introduced the optional altnames field in the network edit
grid. The chosen default configuration however does not even add the
field, therefore setting it to hidden if no altnames data is present
cannot work.

Fix this by only hiding the field if it was actually configured to be
shown in the first place.

Fixes: 691f530d ("network: optionally show alternative interface names")
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/node/NetworkEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index cd9dc7c..601d788 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -465,7 +465,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
                         if (Ext.isArray(data.altnames)) {
                             data.altnames = data.altnames.join('<br>');
                         }
-                    } else {
+                    } else if (me.showAltNames && !me.isCreate) {
                         me.down('field[name=altnames]').setVisible(false);
                     }
                     me.setValues(data);
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pmg-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config

[Christian Ebner]

Commit 691f530d ("network: optionally show alternative interface
names") introduced the optional altnames field in the network edit
grid. The chosen default configuration however does not even add the
field, therefore setting it to hidden if no altnames data is present
cannot work.

Fix this by only hiding the field if it was actually configured to be
shown in the first place.

Fixes: 691f530d ("network: optionally show alternative interface names")
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/node/NetworkEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index cd9dc7c..601d788 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -465,7 +465,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
                         if (Ext.isArray(data.altnames)) {
                             data.altnames = data.altnames.join('<br>');
                         }
-                    } else {
+                    } else if (me.showAltNames && !me.isCreate) {
                         me.down('field[name=altnames]').setVisible(false);
                     }
                     me.setValues(data);
-- 
2.47.2



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

[pbs-devel] applied: [pmg-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config

[Thomas Lamprecht]

On Thu, 31 Jul 2025 13:30:15 +0200, Christian Ebner wrote:
> Commit 691f530d ("network: optionally show alternative interface
> names") introduced the optional altnames field in the network edit
> grid. The chosen default configuration however does not even add the
> field, therefore setting it to hidden if no altnames data is present
> cannot work.
> 
> Fix this by only hiding the field if it was actually configured to be
> shown in the first place.
> 
> [...]

Applied, thanks!

[1/1] network edit: fix hiding of altnames field if disabled by config
      commit: c3bb1497d7f1605a2fe04e89a42a38c0292d8741


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pve-devel] applied: [pmg-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config

[Thomas Lamprecht]

On Thu, 31 Jul 2025 13:30:15 +0200, Christian Ebner wrote:
> Commit 691f530d ("network: optionally show alternative interface
> names") introduced the optional altnames field in the network edit
> grid. The chosen default configuration however does not even add the
> field, therefore setting it to hidden if no altnames data is present
> cannot work.
> 
> Fix this by only hiding the field if it was actually configured to be
> shown in the first place.
> 
> [...]

Applied, thanks!

[1/1] network edit: fix hiding of altnames field if disabled by config
      commit: c3bb1497d7f1605a2fe04e89a42a38c0292d8741


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pmg-devel] applied: [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config

[Thomas Lamprecht]

On Thu, 31 Jul 2025 13:30:15 +0200, Christian Ebner wrote:
> Commit 691f530d ("network: optionally show alternative interface
> names") introduced the optional altnames field in the network edit
> grid. The chosen default configuration however does not even add the
> field, therefore setting it to hidden if no altnames data is present
> cannot work.
> 
> Fix this by only hiding the field if it was actually configured to be
> shown in the first place.
> 
> [...]

Applied, thanks!

[1/1] network edit: fix hiding of altnames field if disabled by config
      commit: c3bb1497d7f1605a2fe04e89a42a38c0292d8741


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel