From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 909741FF183 for ; Wed, 30 Jul 2025 14:48:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 87616D52C; Wed, 30 Jul 2025 14:50:15 +0200 (CEST) Date: Wed, 30 Jul 2025 14:50:07 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20250723144131.170616-1-f.ebner@proxmox.com> <20250723144131.170616-3-f.ebner@proxmox.com> In-Reply-To: <20250723144131.170616-3-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1753879761.f5lt7m7owq.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753879799081 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH container v2 2/4] seccomp config: adapt to new lxc-syscalld runtime directory X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On July 23, 2025 4:40 pm, Fiona Ebner wrote: > The lxc-syscalld now uses a different runtime directory. Its old > runtime directory was /run/pve, which was also used for other things, > e.g. storage tunnel and mtunnel sockets and container stderr logs as > well as pull metrics. The fact that it would be recreated on service > restart is problematic, so the runtime directory was changed. > > Note that this configuration is only used for containers with the > experimental 'mknod' feature enabled. > > For already running containers, a symbolic link is put into place by > the new version of pve-lxc-syscalld, but newly started ones should > always use the new socket path as soon as it is available. Only use > the old socket path if the old version of pve-lxc-syscalld is still > used. The heuristic to check this is: > 1. the new socket path doesn't exist > 2. the old socket path exists > 3. the old socket path is not a symbolic link couldn't this be solved by adding a versioned depends, instead of breaking the other direction which is not actually required because of the compat symlink? > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * adapt to shortened socket path > > src/PVE/LXC.pm | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 741bb33..a236b5a 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -534,7 +534,15 @@ sub make_seccomp_config { > die "'mknod' feature requested, but kernel too old (found $kernel, required >= 5.3)\n"; > } > > - $raw_conf .= "lxc.seccomp.notify.proxy = unix:/run/pve/lxc-syscalld.sock\n"; > + # TODO PVE 10 - always use new socket path > + my $old_socket_path = '/run/pve/lxc-syscalld.sock'; > + my $new_socket_path = '/run/pve-lxc-syscalld/socket'; > + > + if (!-e $new_socket_path && -e $old_socket_path && !-l $old_socket_path) { > + $raw_conf .= "lxc.seccomp.notify.proxy = unix:$old_socket_path\n"; > + } else { > + $raw_conf .= "lxc.seccomp.notify.proxy = unix:$new_socket_path\n"; > + } > $raw_conf .= "lxc.seccomp.notify.cookie = $vmid\n"; > > $rules->{mknod} = [ > -- > 2.47.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel