Re: [pve-devel] [PATCH storage 07/26] common: add pve-storage-vtype standard option with new types

Fiona Ebner
2025-07-29T13:50:09Z

Am 29.07.25 um 1:16 PM schrieb Wolfgang Bumiller:
> This adds the vm-vol and ct-vol vtypes introduced in the upcoming
> commits.
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> src/PVE/Storage/Common.pm | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.pm
> index 222dc76..b2ebd50 100644
> --- a/src/PVE/Storage/Common.pm
> +++ b/src/PVE/Storage/Common.pm
> @@ -59,6 +59,23 @@ PVE::JSONSchema::register_standard_option(
> },
> );
>
> +=head3 pve-storage-vtype
> +
> +Possible vtypes a guest image can have.

IMHO, this should be renamed to make it clear that it's only for guest
images, not all vtypes.

> +
> +=cut
> +
> +PVE::JSONSchema::register_standard_option(
> + 'pve-storage-vtype',
> + {
> + type => 'string',
> + enum => [qw(vm-vol ct-vol images rootdir)],
> + description =>
> + "The volume type indicates whether the volume is meant for VMs or containers."
> + . " The 'images' and 'rootdir' types are for legacy support and should be avoided.",
> + },
> +);
> +
> =pod
>
> =head1 FUNCTIONS