From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 890851FF16B for ; Tue, 29 Jul 2025 21:22:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0B2141BF5B; Tue, 29 Jul 2025 21:23:45 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Stefan Hanreich Date: Tue, 29 Jul 2025 21:21:24 +0200 Message-ID: <175381688321.2683022.7251869854078239677.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250729171649.708219-3-s.hanreich@proxmox.com> References: <20250729171649.708219-1-s.hanreich@proxmox.com> <20250729171649.708219-3-s.hanreich@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753817011939 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH pve-manager v2 1/2] pvestatd: pull metric: use ip link to detect physical interfaces X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, 29 Jul 2025 19:16:44 +0200, Stefan Hanreich wrote: > pve-common now allows arbitrary names for physical interfaces, without > being restricted by PHYSICAL_NIC_RE. In order to detect physical > interfaces, pvestatd now needs to query 'ip link' for the type of an > interface instead of relying on the regular expression. > > On the receiving end, PullMetric cannot consult 'ip link' for > determining which interface is physical or not. To work around that, > introduce a new type key, that carries information about the type of > an interface. When aggregating the metrics, PullMetric can now read > this additional parameter, to infer the type of the interface (either > physical or virtual). > > [...] Applied, thanks! I added a time-based expiry check to re-cache this every 15 minutes in a follow up, it's a very simple check and this way we converge relatively fast while not doing that many updates. [1/2] pvestatd: pull metric: use ip link to detect physical interfaces commit: 83d0b982e6ad498031f0f1d97511b441c98a7706 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel