From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F0E721FF16B for ; Tue, 29 Jul 2025 15:23:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2FA7412999; Tue, 29 Jul 2025 15:24:24 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Shannon Sterz Date: Tue, 29 Jul 2025 15:18:54 +0200 Message-ID: <175379503278.87783.2118363966780967203.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250729121151.159797-1-s.sterz@proxmox.com> References: <20250729121151.159797-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753795421353 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH pve-storage v3] fix #6561: zfspool: track refquota for subvolumes via user properties X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, 29 Jul 2025 14:11:51 +0200, Shannon Sterz wrote: > zfs itself does not track the refquota per snapshot so we need handle > this ourselves. otherwise rolling back a volume that has been resize > since the snapshot, will retain the new size. this is problematic, as > it means the value in the guest config does not longer match the size > of the disk on the storage. > > this implementation tries to do so by leveraging a user property per > snapshot. > > [...] Applied, thanks! Fixed up the capitalization in the commit message and made some minor wording changes. [1/1] fix #6561: zfspool: track refquota for subvolumes via user properties commit: a9315a0ed32293d11a56470d2e19598a5212e8e3 > keeping fiona's R-b from v2 as v3 basically just incorporates her > suggestions (or suggestions she signed off on), but i'd drop the T-b > as these patches now behave somewhat differently (warning on unknown > values). Personally, I prefer if the R-b is dropped if there are non-trivial changes and that such earlier reviews are rather mentioned as part of the changelog for context. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel