From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 35BDA1FF18A for ; Tue, 22 Jul 2025 18:10:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 81D99E3E7; Tue, 22 Jul 2025 18:11:42 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Fiona Ebner Date: Tue, 22 Jul 2025 18:10:29 +0200 Message-ID: <175320062712.1749140.8143788964706302076.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250718154503.179257-1-f.ebner@proxmox.com> References: <20250718154503.179257-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753200689703 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server] blockdev: also set read-only flag on top throttle node X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri, 18 Jul 2025 17:44:57 +0200, Fiona Ebner wrote: > QEMU will try to set the write permission on a device even if it's > just the throttle filter that is not marked as read-only. This causes > VM start to fail when a drive with the Proxmox VE-specific 'ro' flag > is configured and also template backup. Properly set the flag also > for the top throttle node. > > > [...] Applied, thanks! FWIW, I shortly thought about if it makes sense to only add the read-only param if it's true, to avoid adding extra "bloat" to the CLI, but it's not _that_ much more and being more expressive might pay off, so I kept it as is. [1/1] blockdev: also set read-only flag on top throttle node commit: d763b72462d777b908237014b868e5009c902b57 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel