From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D5EE71FF183 for ; Wed, 16 Jul 2025 00:36:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16F6C1066A; Wed, 16 Jul 2025 00:37:07 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Lukas Wagner Date: Wed, 16 Jul 2025 00:34:23 +0200 Message-ID: <175261886148.2461757.14618724142093826900.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250627121339.182283-1-l.wagner@proxmox.com> References: <20250627121339.182283-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH proxmox-widget-toolkit 1/3] fix #5588: notification: smtp: fix 'Authenticate' checkbox in Chromium X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri, 27 Jun 2025 14:13:37 +0200, Lukas Wagner wrote: > When editing an SMTP endpoint that has no authentication settings, in > Chromium-based browsers, the 'Authenticate' checkbox was ticked because > of a race condition between the view-model default and the InputPanel > logic setting the existing values for the endpoint. Explicitly setting > the value in the view model in onSetValues seems to fix this reliably. > > Tested on: > - Firefox 140 > - Chromium 137 > - Chrome 138 > - Gnome Web (Webkit-based) 48 > > [...] Applied, thanks! btw. adding a cover-letter to any series with a few patches might be nice in any case, as that allows replying with R-b/T-b on that and make it clarify that they should be applied to the whole series to both devs and b4, the cover-letter itself can be very basic. Here I applied Michael's trailer to all patches and Maximiliano just to the one he replied too, as it would be fiting for him to review translation stuff, so I figured it's really just for that part. [1/3] fix #5588: notification: smtp: fix 'Authenticate' checkbox in Chromium commit: ca138ff8d0dc8687ddfe9e4e448342e1fe1fb8a0 [2/3] notification: smtp: only show 'Unchanged' in password field when it makes sense commit: f47eec10122e5e8a25f5d76411cbef9d18ebc022 [3/3] notification: smtp: don't split translatable string commit: dc5d616d72e41b805155165aeb1c81c7fe7d058c _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel