From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7EC451FF164 for ; Fri, 20 Jun 2025 13:33:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA7D5A492; Fri, 20 Jun 2025 13:34:00 +0200 (CEST) Date: Fri, 20 Jun 2025 13:33:53 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20250618130209.90649-1-f.ebner@proxmox.com> <20250618130209.90649-19-f.ebner@proxmox.com> In-Reply-To: <20250618130209.90649-19-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1750419025.58h76uvcfk.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v2 18/32] vm start/commandline: activate volumes before config_to_command() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On June 18, 2025 3:01 pm, Fiona Ebner wrote: > With '-blockdev', it is necessary to activate the volumes to generate > the command line, because it can be necessary to check whether the > volume is a block device or a regular file. > > Do not deactivate after commandline generation for 'qm showcmd', > because there can be concurrent operations acting on the volumes. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * Do not deactivate after showcmd, because it might not be safe. > > src/PVE/QemuServer.pm | 60 +++++++++++++++++++++------- > src/test/run_config2command_tests.pl | 10 +++++ > 2 files changed, 55 insertions(+), 15 deletions(-) > > diff --git a/src/test/run_config2command_tests.pl b/src/test/run_config2command_tests.pl > index 590f80f5..cbd8cd8b 100755 > --- a/src/test/run_config2command_tests.pl > +++ b/src/test/run_config2command_tests.pl > @@ -256,6 +256,16 @@ $qemu_server_module->mock( > }, > ); > > +my $storage_module = Test::MockModule->new("PVE::Storage"); > +$storage_module->mock( > + activate_volumes => sub { > + return; > + }, > + deactivate_volumes => sub { > + return; > + }, > +); > + potential for some follow ups here - we could actually track what the tests trigger here, and thus that - only actively referenced volumes are activated, and unused volumes for example are not - backing chains are properly activated (once those are a thing) - showcmd doesn't deactivate - ..? > my $zfsplugin_module = Test::MockModule->new("PVE::Storage::ZFSPlugin"); > $zfsplugin_module->mock( > zfs_get_lu_name => sub { > -- > 2.39.5 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel